Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for decision]: ADR for imports vs. ambient types #4

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tristanmenzel
Copy link
Collaborator

No description provided.

@tristanmenzel tristanmenzel changed the title docs: Draft ADR for imports vs. ambient types docs: ADR for imports vs. ambient types Jun 6, 2024
@Loedn
Copy link
Contributor

Loedn commented Jun 7, 2024

Option 2 on this is the way to go in my opinion, the quality of intellisense is crucial to devux

@joe-p
Copy link
Contributor

joe-p commented Jun 7, 2024

Option 2 on this is the way to go in my opinion, the quality of intellisense is crucial to devux

Agreed. Might be too granular for this ADR but I do think it's worth thinking about how they are imorted

For example:

import { vrfVerify, mullw } from '@algorandfoundation/puya'

...

vryVerify(...)
mulw(...)

vs

import { crypto, math } from '@algorandfoundation/puya'

...

crypto.vryVerify(...)
math.mulw(...)

I think breaking it down into packages so not every single opcode needs to be individually imported makes the most sense

@tristanmenzel tristanmenzel changed the title docs: ADR for imports vs. ambient types [Ready for decision]: ADR for imports vs. ambient types Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants